Temporarily change /system/* -> /sys/*#1192
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
sys-routes
branch
from
30e1954 to
d1e81ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
/system/*routes don't work when the console is served by Nexus because there is no handler for/system/*like we have for/orgs/*and/settings/*. The problem (see oxidecomputer/omicron#430) is that/system/routes already exist in the API, so we can't use/system/*, and we can't even use the direct names because there's already a/system/silosin the API. So until we resolve that (hopefully soon) I am going to cheat and use/sysin the console. Ew.Goes with oxidecomputer/omicron#1764. Will bump Omicron's console version once that's merged.